Skip to content

Conversation

seer-by-sentry[bot]
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Aug 1, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. The issue was that: Inaccessible paths cause COMException during layout preference retrieval via low-level Windows file system API calls.
  2. Added a check to ensure the path is accessible before attempting to retrieve layout preferences from the database.
  3. If the path is inaccessible, the default layout preferences are returned.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 580156

Not quite right? Click here to continue debugging with Seer.

{
try
{
return !string.IsNullOrEmpty(path) && Directory.Exists(path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also paths that indicate the home page or tag search results, but this code ignores them and is inappropriate.

@yaira2 yaira2 closed this Aug 21, 2025
@yaira2 yaira2 deleted the seer/fix/inaccessible-path-layout-preferences branch August 21, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants